menu
Channels
# All channels
view-forward
# General
view-forward
# Announcements
view-forward
# Docs
view-forward
# JavaScript
view-forward
# Peril
view-forward
# Ruby
view-forward
# Swift
view-forward
Team

Contributing / Local Danger Development Workflow

September 28, 2019 at 1:18pm

Contributing / Local Danger Development Workflow

September 28, 2019 at 1:18pm
I forked the repo to see what the contrib workflow would be. Build it fine. Attempting to see how it would work on an actual template iOS app. Ran 'yarn add file:./../../node/danger-js --dev' in this template iOS app directory. Hoping to get that version of danger with my changes. ran 'yarn install' to install danger which appeared to work. ran 'yarn danger' and it just doesn't show up 'command danger not found'
Using nvm - 10.15, updated yarn.
I haven't contributed js / ts based projects so I'm not sure if this is an ideal workflow or I'm just doing something wrong. Any thoughts?

September 28, 2019 at 3:40pm
I wonder if you need to run yarn build (or compile?) in the danger-js rep first
  • reply
  • like
Yep simple as that thanks!... I had run yarn test several times sort of expected that to implicitly build. Is this a typical workflow for this type of development? Any tips?
  • reply
  • like

October 4, 2019 at 7:01pm
Personally I don't really work like that, I tend to do everything against tests and then make a local build to run against at the end. I think there might be a watch command which would automatically make it build, but that's how normal node dev is
  • reply
  • like