menu
Channels
# All channels
view-forward
# General
view-forward
# Announcements
view-forward
# Docs
view-forward
# JavaScript
view-forward
# Peril
view-forward
# Ruby
view-forward
# Swift
view-forward
Team

I guess git.modified_files and git.added_files may be bugged

October 8, 2019 at 10:30am

I guess git.modified_files and git.added_files may be bugged

October 8, 2019 at 10:30am
I have a detection if sql files are edited, to add a database engineer as a reviewer. Currently i am detecting these changes via
modified_sql = !(git.modified_files.grep(%r{.sql.stg}).empty?) added_sql = !(git.added_files.grep(%r{.sql.stg}).empty?)
Now i have the following situation in my workflow:
  • MR 1 is opened with changes to SQL
  • MR 2 is opened without changes to SQL
  • Danger adds database engineer to the reviewer list of MR 1
  • MR 1 is merged into master
  • MR 2 is rebuild because of changes to master
  • Danger detects the changes of MR 1 in master as modified / added files in MR 2 -> Database engineer is added as a reviewer to MR 2
No messages yet