menu
announcement

Spectrum is now read-only. Learn more about the decision in our official announcement.

Gitmeme

A fun tool to add memes to Github

Channels
Team

This is amazing! Any chance of getting it for FF?

October 7, 2019 at 6:50pm

This is amazing! Any chance of getting it for FF?

October 7, 2019 at 6:50pm

October 17, 2019 at 11:29pm
Thanks! I'm looking into getting it on Firefox - their requirements for shipping an extension in their store are annoyingly onerous, which is slowing things down a lot compared to Chrome
Awesome! My next question is GH Enterprise...
It works on GH Enterprise but it would be necessary to add each instance to the URL whitelist. Each time this happens it disables the extension for all users, until they manually turn it back on. So, I don't know how to gradually enable it for new GHE instances without messing it up for everyone who installed it :-(
We added it ourselves in the preferences file and it shows up in the extention info, but still doesn't actually work
Hmm good to know - and I didn't know you could manually do it. I'd need access to a GHE instance to test it out. I don't suppose you have an empty test instance hanging around?
I edited .config/google-chrome/Default/Preferences, looked for instances like git.musta.ch, and shoved in our GHE hostname into the lists. Our URL shows up in the "Site access" list when we look at extension properties, but didn't seem to do the trick.
The question is whether the extension is loading at all, or if it is loading and there's something sufficiently different about the DOM in GHE that prevents it from working
Hard to tell without getting in there myself :-(
what can we do to help debug

October 23, 2019 at 4:15pm
Hmm, I think I'll have to separate out the client and server portions of this into different repositories, and give you access to the client side. The server side still has a bunch of credentials and stuff that I'll need to remove first...

October 30, 2019 at 10:15pm
sure. in the meantime, can we provide chrome console logs or anything
also, I just installed it fresh, and the part on the website that claims you can add your ownservers... no such option exists:
however if I add it to the two lists in Default/Preferences like so:
Edited
[[email protected] chromium]$ diff -u <(jq . Default/Preferences) <(jq . Default/Preferences.bak )
--- /dev/fd/63 2019-10-30 15:22:11.881753447 -0700
+++ /dev/fd/62 2019-10-30 15:22:11.881753447 -0700
@@ -887,8 +887,7 @@
"scriptable\_host": [
"https://_.github.com/_",
"https://git.musta.ch/\*",
- "https://github.com/\*",
- "https://github.corp.vicarious.com/\*"
- "https://github.com/_"
]
},
"commands": {},
@@ -911,8 +910,7 @@
"scriptable\_host": [
"https://_.github.com/_",
"https://git.musta.ch/_",
- "https://github.com/\*",
- "https://github.corp.vicarious.com/\*"
- "https://github.com/\*"
]
},
"incognito\_content\_settings": [],
Edited
then it shows up in prefs
that diff is obv backwards, sorry
oh, found a third place:
@@ -887,7 +888,8 @@
"scriptable_host": [
"https://*.github.com/*",
"https://git.musta.ch/*",
- "https://github.com/*"
+ "https://github.com/*",
+ "https://github.corp.vicarious.com/*"
]
},
"commands": {},
@@ -910,7 +912,8 @@
"scriptable_host": [
"https://*.github.com/*",
"https://git.musta.ch/*",
- "https://github.com/*"
+ "https://github.com/*",
+ "https://github.corp.vicarious.com/*"
]
},
"incognito_content_settings": [],
@@ -944,7 +947,8 @@
"matches": [
"https://*.github.com/*",
"https://github.com/*",
- "https://git.musta.ch/*"
+ "https://git.musta.ch/*",
+ "https://github.corp.vicarious.com/*"
]
}
],
and I don't see any errors in the web developer console
OHHHHHH!!!
it works in Chrome, but not Chromium
on my machine that's chrome 78 and chromium 76

November 1, 2019 at 5:30pm
- does that make any sense to you?
So, to clarify, is it working for you now in standard Chrome?
Also, thanks for digging!
Show more messages