menu
Channels
Team
Posts
Chat
Members
Info

November 12, 2019 at 4:44am
Hey , this is a bit quicker than email
  • reply
  • like
Just in case I messed something up when making the cut down version I sent you via email, you can now just check out the code directly from https://github.com/shaneosullivan/gitmeme
Edited
  • reply
  • like
you have to PR's
  • reply
  • like
two*
  • reply
  • like
a few lessons learned: 1. console.log() works fine in chrome, but not chromium (that was the first hour of my debugging). 2. yarn watch either lies, or builds some sort of special build in which console log doesn't work.
  • reply
  • like

November 12, 2019 at 7:10pm
Really strange about console.log() in Chromium....
  • reply
  • like
Thanks for the PRs! They're merged and I've submitted a new version of the extension to Google. It should be live in an hour or two
  • reply
  • like
sweet thanks! Btw, you said the Firefox process was more difficult... but does tht mean the code should otherwise work on FF?
  • reply
  • like
Yeah it should. Firefox duplicated all APIs from Chrome to make it easy
  • reply
  • like
I made a start on this where it packages up the Firefox extension and it's source code (they make you send the source code too), but I remember running into more roadblocks. I'll look into it again in the coming weeks
  • reply
  • like

November 13, 2019 at 6:54am
how do I go about building it for FF?
  • reply
  • like
I'll just do a local install
  • reply
  • like
also... I don't think you changed the version number before you submitted to google?
  • reply
  • like

November 13, 2019 at 3:09pm
Google have stuck the extension in review, it’s taking a while to get released
  • reply
  • like
ill get back to you in a bit about FF
  • reply
  • like

November 15, 2019 at 8:10pm
- still no approval from google?!
  • reply
  • like
also, what any thoughts on how I build for FF locally?
  • reply
  • like
Hmm, still pending review, what the hell.....
  • reply
  • like
For FF, run the build, and you should see a FirefoxExtension.zip. In Firefox, you can go to: about:addons and install that zip from the gear icon. It'll complain about the zip not being signed, which is where I stopped the last time. There's info at https://support.mozilla.org/en-US/kb/add-on-signing-in-firefox on how to resolve this. It's a pain in the neck, but if you really care about getting it on FF, please go for it!
  • reply
  • like

November 18, 2019 at 11:37pm
v1.8 is published now, please let me know how it works for you
  • reply
  • like
So it wasn't working, but then I noticed I had two versions of 1.8 installed. I removed both of them, restarted, added it back, then exited the browser, modified my Preferences file to add the GHE URL to all 3 places, then started the browser and it worked. Is there any way we can make the match sites editable without having to muck with the Preferences file?
  • reply
  • like