menu
announcement

Spectrum is now read-only. Learn more about the decision in our official announcement.

Primer

For discussing Primer, Octicons, our style guide, and design systems at GitHub πŸ€–πŸŽ¨

Channels
Team

Open office hours - 07/27/18

July 27, 2018 at 7:07pm

Open office hours - 07/27/18

July 27, 2018 at 7:07pm
Talk to us about what we're learning from building Primer-react βš›οΈ, ask us about this week's releases πŸš€, working at GitHub πŸ€— and building design systems πŸ€–πŸŽ¨

July 27, 2018 at 7:37pm
πŸ‘‹πŸΌ
(little early, I know) Just kicking it off
like-fill
2
Hey hey! Thanks for your contributions to Primer this release !
I'm working on releasing them right now!
like-fill
1
Ha, not a problem! Always happy to pick up a couple loose end issues floating around.
like-fill
1
πŸ‘‹ Hello. I'm looking at https://styleguide.github.com/primer/ and it is super nice.
Thanks ! It's definitely a work in progress still :D
whoops, !
Also, regarding:
Our style guide is a Jekyll site, and we have a script in that repo that pulls all of the docs from whatever version of Primer we have installed there, adds a bunch of front matter, then puts them into the Jekyll source directory. In the future, we're probably going to move away from Jekyll and use something Node-based so that we can formally import the docs as dependencies rather than just copying files around.
Has there been any discussion related to Gatsby for doing exactly this? You could do a lot with it to aid in this case and it would pretty much fit the bill for exactly what y'all are after.
Moreover, it's built with React, still a static site generator like Jekyll and with the React-primer progress would be a fantastic consideration.
Yeah, we've definitely been thinking about the possibility of rebuilding using something React based, especially if we could use our primer-react components to build it!
Would be good dog fooding experiment :)
Are y'all still using Storybook?
Thought I saw an old iteration of the style guide (or component docs) or Storybook somewhere…
the styleguide uses jekyll, but Primer does have a storybook option too
like-fill
1
We're using Storybook with our Primer CSS package, but we're using Kit for our primer-react stuff!
I've become a huge fan of Gatsby in the last few months and it's been a breath of fresh air regarding site building for a variety of reasons, but the way you can source information, even documentation based on Primer versions could be entirely automated. (Fanboy'ing at this point, sorry)
Oooh that would be really nice! We have a lot of that set up with Jekyll right now but it's a little clunky to be totally blunt πŸ˜‚
Is that ever something that would become public facing? I'm about to experiment with concepts for lodash.com to help complete a very similar type project and I'd be able to help share whatever I learn from that
Interesting, haven't heard of Kit. Have a link?
Also, when (roughly?) is Primer-react going to be made available to us public peons, is it typed, webpack or parcel, and are there any current pain points that the team is having that you're hoping community members can help with
We actually talked a bunch about this last week if you want to check out the conversation https://spectrum.chat/thread/0d7dc001-2cf6-4f61-8acd-047e2003c211?m=MTUzMjEyMzA3NDU5Ng==
here is the Kit site though: https://compositor.io/kit/
like-fill
1
Our main focus is discovering our voice with primer-react and how we want our Components/API to interact. This is new territory for GitHub, and half of the design systems team. Because of this, we're very often introducing breaking changes with every beta release.
Yes, we will be open-sourcing primer-react as soon as we can. We're going to start with inviting interested folks (external and internal) to the repo for feedback and testing when we have a good beta release, and then we'll it fully public.
Show more messages