menu
announcement

Spectrum is now read-only. Learn more about the decision in our official announcement.

Theia

Eclipse Theia - Cloud & Desktop IDE

Channels
Team

Call Hierarchy Plugin API

January 14, 2020 at 3:49pm

Call Hierarchy Plugin API

January 14, 2020 at 3:49pm
Hi folks, I'm taking a stab at implementing https://github.com/eclipse-theia/theia/issues/3765 based on 's old PR. The current CallHierarchyService is chosen based on a "languageId", but the vscode API uses a DocumentFilter. Also, the VS Code API supports incoming and outgoing calls, whereas our current on only supports one call direction. Supporting those new features would be a breaking change. The question now is how to handle this. The two options would be to have a breaking change, forcing folks to rewrite their CallHierarchyService implementations or I could implement a "legacy" layer that would allow current services to function. The downside there is that the nice names are already taken by the current implementation, so it would be a kind of kludge. What do you think?

January 15, 2020 at 2:09am
It should be fine to break. I don't think anyone extend it and it is not used a lot.
like-fill
1