Keybindings have collision
October 16, 2019 at 7:57amKeybindings have collision
October 16, 2019 at 7:57amKeybindings for
Go to definition
and Go to implementation
commands have collision, both are bound with ctrl+f12
. Looks like the problem is related to the issue https://github.com/microsoft/monaco-editor/issues/1407.
Does it make sense to change default keybinding for Go to definition command and set it as ctrl+f11
, WDYT?October 16, 2019 at 8:43am
in the electron version of theia, they are bound to f12 and <ctrl>f12 respectively. If we can rebind "goto definition", why not rebind it to f12? Or is this a browser/electron issue?
I know that f12 opens the devtools, but that is als available via a menu, right?
I think it makes sense to rebind it, not sure what will be the good keybinding. if
ctrl+f11
is free for browser and does not do anything special on different OS then it should be fine. We can also try to use another modifier, i.e. shift+f12
.It would be good to have an issue for it.
October 17, 2019 at 11:29am
ctrl+f11
is free and doesn't have any effects for browser and OSs. shift+f12
is bound for Peek References
. The PR to rebind is here https://github.com/eclipse-theia/theia/pull/6411