PR final approval https://github.com/theia-ide/theia/pull/3804
December 18, 2018 at 8:24amPR final approval https://github.com/theia-ide/theia/pull/3804
December 18, 2018 at 8:24amsince is on PTO is it still possible to get final approval for https://github.com/theia-ide/theia/pull/3804
December 18, 2018 at 8:28am
Anton mentioned something along the lines that you should not just rename the components but move them. Not sure what he was referring to exactly, but it was when he was about to leave for holidays. He will be back on January 4.
I would prefer if I don't need to look into it before Christmas as I have so many other things on my list. Would it be ok to clarify this in the beginning of January?
I guess they are the same requirements as for https://github.com/theia-ide/theia/pull/3805
Did you mean this one?
December 19, 2018 at 6:57am
Yes, the second comment about the implicit dependency `debug -> plug-in` it is. The debug extension should not have anything specific for the plug-in system.
thanks for your reply. Didn't know you were sick, so have good recovery !
December 22, 2018 at 10:24am
December 26, 2018 at 8:12am
January 2, 2019 at 10:56am