menu
announcement

Spectrum is now read-only. Learn more about the decision in our official announcement.

Theia

Eclipse Theia - Cloud & Desktop IDE

Channels
Team

PR final approval https://github.com/theia-ide/theia/pull/3804

December 18, 2018 at 8:24am

PR final approval https://github.com/theia-ide/theia/pull/3804

December 18, 2018 at 8:24am
since is on PTO is it still possible to get final approval for https://github.com/theia-ide/theia/pull/3804

December 18, 2018 at 8:28am
Anton mentioned something along the lines that you should not just rename the components but move them. Not sure what he was referring to exactly, but it was when he was about to leave for holidays. He will be back on January 4.
I would prefer if I don't need to look into it before Christmas as I have so many other things on my list. Would it be ok to clarify this in the beginning of January?
I might miss something, which comment are you referring to?
He mentioned that to me in direct conversation when he left the office. Sorry.
Hello, AFAIK Anatolii's team need debug plug-in support for theia 0.3.18 which is released before end of this year. How can we move forward ?

December 19, 2018 at 6:57am
Sorry, I went offline being sick yesterday. Will look into it now.
Yes, the second comment about the implicit dependency `debug -> plug-in` it is. The debug extension should not have anything specific for the plug-in system.
Edited
Get better soon.
I will update PR today then.
I already commented on the PR. If you know what Anton meant please update it. If not we can do the changes after merge, too.
thanks for your reply. Didn't know you were sick, so have good recovery !
I'm fine already again. But thank you :)

December 22, 2018 at 10:24am
I've fix Anton's remark.
So I am going to merge the PR. If he have any questions I will fix them ASAP.

December 26, 2018 at 8:12am
It turned out that front-end plugings stopped working. I am fixing..

January 2, 2019 at 10:56am
hi, thanks for taking care about it