menu
announcement

Spectrum is now read-only. Learn more about the decision in our official announcement.

Theia

Eclipse Theia - Cloud & Desktop IDE

Channels
Team

TreeViewsMain missing part of VSCode api?

October 25, 2019 at 7:46pm

TreeViewsMain missing part of VSCode api?

October 25, 2019 at 7:46pm
TreeView.reveal() is currently supported according to this doc: https://che-incubator.github.io/vscode-theia-comparator/status.html
But apparently that is not the case. I have an extension where the reveal() currently works in VSCode but doesn't seem to do much in Theia. Also, I was taking a look in the source code and looks like the selectionOptions are not being taken into account (select is never used, focus and expand are missing): https://github.com/eclipse-theia/theia/blob/65d5925d450d529be45902b23f421d393211d38c/packages/plugin-ext/src/plugin/tree/tree-views.ts#L199

October 26, 2019 at 6:06am
Hi , unfortunately at the beginning we were accepting PRs stubbing VS Code apis. We are trying not to accept anymore such PRs, but ask for the proper implementation. Although it is not always possible.
Edited
For this case, could you please file an issue? PRs are welcomed as well.

October 28, 2019 at 5:31am
we should do a pass over the API implementation to find stubs and track them.

October 29, 2019 at 6:17am
it would be helpful if someone does it, but it is quite tedious to check whether each property of each interface is actually used, sometimes it seems to be used, i.e. someone even copied it and passed to the main process but then did not do anything with it :( big parts like file system provider and editor comment contributors should be tracked already
Edited
Would running the VS Code API tests (https://github.com/eclipse-theia/theia/issues/4224) be sufficient to track down the stub implementations? Does it cover all API's?
I don't know, it will catch some cases but I doubt that all will be covered