danger / Peril

Heroku Peril `this.platform.getInlineComments` not found

Heroku Peril `this.platform.getInlineComments` not found

danger/Peril · April 25, 2018 at 4:11pm

Heroku Peril `this.platform.getInlineComments` not found

danger / Peril · April 25, 2018 at 4:11pm

Hey everyone! I'm trying to set up danger for my org and I've been having a bunch of stumbling blocks. I have everything setup and danger is running, but I can't seem to get the bot to comment on my issues.
https://gist.github.com/milesalex/790cf4b2ad1dcf9002406b1249e05170
I'm modeling my danger settings after spectrum (woo!): https://github.com/TokenTax/peril

Any tips on why this would happen?

gist:790cf4b2ad1dcf9002406b1249e05170
https://gist.github.com/milesalex/790cf4b2ad1dcf9002406b1249e05170

April 25, 2018 at 4:20pm

Another great catch, since inline comments were added to Danger, I've not tested them on Peril, I'm about 95% sure that https://github.com/danger/peril/pull/243 will fix this

like-fill
2
  • reply
  • like

@orta was unsure if this was a bug so I asked here! :)

  • reply
  • like

@orta How do I redeploy to test out the latest PR? Does it happen on restart?

  • reply
  • like

Apparently it works with PRs but not issues

  • reply
  • like

To redeploy you push the changes to the heroku remote, you'd have to clone a copy of peril locally

  • reply
  • like

then you can go into your org app for peril and make GitHub re-send the webhooks in the advanced section

like-fill
1
  • reply
  • like

I'm not too surprised about inline reporting not working when running from an issue webhook. I'll need to document that, can you show me what you were trying to do, I'm kinda interested/

  • reply
  • like
2018-04-25T21:34:53.410882+00:00 app[web.1]: Failing the build, there is 1 fail.
2018-04-25T21:34:53.419617+00:00 app[web.1]: error: Error: TypeError: previousComments.filter is not a function
2018-04-25T21:34:53.419620+00:00 app[web.1]: at Executor.sendInlineComments (/app/node_modules/danger/distribution/runner/Executor.js:365:47)
2018-04-25T21:34:53.419622+00:00 app[web.1]: at Executor.<anonymous> (/app/node_modules/danger/distribution/runner/Executor.js:305:51)
2018-04-25T21:34:53.419624+00:00 app[web.1]: at step (/app/node_modules/danger/distribution/runner/Executor.js:32:23)
2018-04-25T21:34:53.419625+00:00 app[web.1]: at Object.next (/app/node_modules/danger/distribution/runner/Executor.js:13:53)
2018-04-25T21:34:53.419627+00:00 app[web.1]: at fulfilled (/app/node_modules/danger/distribution/runner/Executor.js:4:58)
2018-04-25T21:34:53.419629+00:00 app[web.1]: at <anonymous>
2018-04-25T21:34:53.419630+00:00 app[web.1]: at process._tickCallback (internal/process/next_tick.js:182:7)
2018-04-25T21:34:53.420012+00:00 app[web.1]: /app/out/peril.js:19
2018-04-25T21:34:53.420014+00:00 app[web.1]: throw reason;
  • reply
  • like

aOh vey. Now its failing on `TypeError: previousComments.filter is not a function`

  • reply
  • like
  • reply
  • like

I'm trying to get the issue to close automatically if no info has been filled out

  • reply
  • like

April 27, 2018 at 9:55am

Cool, makes sense, I'd recommend using the GitHub API for this - maybe I have to remove `message`/`markdown`/`fail` entirely from an issue

  • reply
  • like
  • reply
  • like
Your message here...

*bold*_italic_`code````codeblock```