Sign in to join this conversation, and others like it, in the communities you care about.
Spectrum chat for Danger
Does danger work better on circle CI v2?
Build still failing, but fail-on-errors is false
Documentation for GitHubDSL.requested_reviewers is wrong
dangerJS does't understand `// @noflow`?
danger / General
It's mainly a matter of figuring out what a plugin should look like, either as a function which can take any webhook ( like what my internal "plugins" are, https://github.com/danger/peril/blob/685e34cd3564c2786aeb5416a6a636623db871af/source/routing/router.ts#L21-L42 ) or whether they should define rules and their own own dangerfiles e.g. just this https://github.com/artsy/peril-settings/blob/master/peril.settings.json#L13-L14
but I've been so strapped for time, I've not really thought much about it
I like the second one a lot
If you showcase in the docs that you can pass an array to the event type
This is what my current Peril plugins look like: https://github.com/withspectrum/danger-plugin-labels
The nice part about that is that it allows configuration—your second version doesn't, you can't configure it
Yeah actually maybe mine's better 😜
that's a danger plugin though, not a peril one, they're different abstractions
Uhhh I use it with Peril haha
It's just called danger-plugin because I initially used it with Danger
It's a Danger plugin because it runs inside a dangerfile :P
a peril plugin should sit above that, and can also run dangerfiles