danger / General

Does danger work better on circle CI v2?

Does danger work better on circle CI v2?

danger/General · June 18, 2018 · 4:11pm

June 19, 2018 · 7:13am

It works very well for us! Using CircleCI v2

  • reply
  • like

We do have "Only build Pull Requests" checked though

  • reply
  • like

June 19, 2018 · 3:11pm

Doesn't that disrupt your workflow? If you commit directly on a branch like staging for example, and you have auto-deployments set up, then your CI will not run any tests and you'd have to manually deploy your app in that case.

I'm not sure I could work with that setting turned on

  • reply
  • like

June 20, 2018 · 7:54am

CircleCI automatically runs builds on the default branch, so our default branch just deploys to staging. We do manual prod deploys, but you could also add a "manual intervention" thingie where you go into CircleCI and press a button to deploy to prod.

  • reply
  • like

Yeah, we also moved a bunch of our danger work to happen on travis and peril instead of on Circle which is our main CI service in artsy.

  • reply
  • like
Your message here...

*bold*_italic_`code````codeblock```