danger / General

Does danger work better on circle CI v2?

Does danger work better on circle CI v2?

danger/General · June 18, 2018 at 4:11pm

Does danger work better on circle CI v2?

danger / General · June 18, 2018 at 4:11pm
The docs about circle CI appear to be a bit old as they're still targeting v1 of circle CI.

Has someone integrated danger with v2 and experienced any of the unreliable PR detection issues mentioned?

"For setting up Circle CI, we recommend turning on "Only Build pull requests." in "Advanced Setting." Without this enabled, it is really tricky for Danger to know whether you are in a pull request or not, as the environment metadata isn't reliable. This may be different with Circle v2."

I'd love to avoid only building PRs on our CI :)

June 19, 2018 at 7:13am

It works very well for us! Using CircleCI v2

  • reply
  • like

We do have "Only build Pull Requests" checked though

  • reply
  • like

June 19, 2018 at 3:11pm

Doesn't that disrupt your workflow? If you commit directly on a branch like staging for example, and you have auto-deployments set up, then your CI will not run any tests and you'd have to manually deploy your app in that case.

I'm not sure I could work with that setting turned on

  • reply
  • like

June 20, 2018 at 7:54am

CircleCI automatically runs builds on the default branch, so our default branch just deploys to staging. We do manual prod deploys, but you could also add a "manual intervention" thingie where you go into CircleCI and press a button to deploy to prod.

  • reply
  • like

Yeah, we also moved a bunch of our danger work to happen on travis and peril instead of on Circle which is our main CI service in artsy.

  • reply
  • like
Your message here...

*bold*_italic_`code````codeblock```