danger / Peril

Running Peril and Danger in parallel

Running Peril and Danger in parallel

March 16, 2018 · 11:35am
Based on this thread it'd require some work to upload test results to a remote server to validate them in Peril. (something Danger can do due to being run on the CI server, so it can read local files)
Until that hosting API is available, can one run Danger and Peril in parallel so that Peril does all the non-fs-actions and then Danger does all the fs-required actions? Would that mean we get two comments on each PR? Can we make them use the same one somehow?

March 16, 2018 · 2:09pm

Yep, that's what we do all over Artsy (here's one https://github.com/artsy/eigen/pull/2566 )- it would mean two comments, and no - they can't be merged. The local danger-js wouldn't have access to edit the comments of Peril, but in theory peril could support merging it's issue with a Danger one, but

like-fill
0

ergh, support line breaks :P

like-fill
0

but, I'm not sure I'd want that complexity in Peril yet

like-fill
0

Makes sense, that's fair, especially since it'd really be a stop-gap solution

like-fill
0

(we support line breaks, just do shift+enter!)

like-fill
0

(not on mobile I guess, gotta fix that)

like-fill
0
Your message here...

**bold***italics*`code````preformatted```