danger / JavaScript

Documentation for GitHubDSL.requested_reviewers is wrong

Documentation for GitHubDSL.requested_reviewers is wrong

danger/JavaScript · June 28, 2018 at 8:41am

Documentation for GitHubDSL.requested_reviewers is wrong

danger / JavaScript · June 28, 2018 at 8:41am
The documentation states the following.
requested_reviewers: array<GitHubUser>

I assume the github call below is used. So to get the actual users you would have to use requested_reviewers.users
https://developer.github.com/v3/pulls/review_requests/

June 28, 2018 at 10:01pm

interesting, we saw this in danger-swift, so maybe the JS types need updating, want to try take a look?

  • reply
  • like

June 29, 2018 at 4:54am

making a PR to the gitlab repo?

  • reply
  • like

June 29, 2018 at 12:28pm

Yep

  • reply
  • like
Your message here...

*bold*_italic_`code````codeblock```